Skip to content

[Network] Random fixes#1407

Closed
AutorestCI wants to merge 1 commit intoAzure:masterfrom
AutorestCI:RestAPI-PR1603
Closed

[Network] Random fixes#1407
AutorestCI wants to merge 1 commit intoAzure:masterfrom
AutorestCI:RestAPI-PR1603

Conversation

@AutorestCI
Copy link
Copy Markdown
Contributor

@AutorestCI AutorestCI commented Aug 31, 2017

Generated from RestAPI PR: Azure/azure-rest-api-specs#1603

@AutorestCI AutorestCI mentioned this pull request Aug 31, 2017
Merged
10 tasks
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 31, 2017 •
edited
Loading

Codecov Report

Merging #1407 into master will decrease coverage by 0.01%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1407      +/-   ##
=========================================
- Coverage   52.61%   52.6%   -0.02%     
=========================================
  Files        3299    3299              
  Lines       83894   83919      +25     
=========================================
+ Hits        44145   44146       +1     
- Misses      39749   39773      +24
Impacted Files Coverage Δ
...ons/network_interface_load_balancers_operations.py 37.5% <ø> (ø) ⬆️
...etwork/v2017_08_01/operations/usages_operations.py 93.75% <ø> (ø) ⬆️
...ork/azure/mgmt/network/v2017_08_01/models/usage.py 100% <100%> (ø) ⬆️
...t/network/v2017_08_01/network_management_client.py 96.63% <100%> (-0.03%) ⬇️
.../operations/virtual_network_gateways_operations.py 16.83% <4%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a893677...c617a2b. Read the comment docs.

@lmazuel lmazuel changed the title Automatic PR from RestAPI-PR1603 [Network] Random fixes Sep 7, 2017
@lmazuel
Copy link
Copy Markdown
Member

lmazuel commented Sep 12, 2017

Network handled manually

@lmazuel lmazuel closed this Sep 12, 2017
azure-sdk pushed a commit that referenced this pull request Feb 13, 2021
@heaths @azure-sdk
Improve TestResources docs and logging
2f10503 
Resolves #1388
Resolves #1407

Also ignores cached service principal if it no longer exists. I ran into this while testing since I cleaned up old SPs.
azure-sdk added a commit that referenced this pull request Feb 13, 2021
@azure-sdk @heaths
Sync eng/common directory with azure-sdk-tools for PR 1408 (#16734)
7f88fa3 
* Improve TestResources docs and logging

Resolves #1388
Resolves #1407

Also ignores cached service principal if it no longer exists. I ran into this while testing since I cleaned up old SPs.

* Add ADP test sub to look-up

Co-authored-by: Heath Stewart <heaths@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AutorestCI @codecov-io @lmazuel @msftclas